Fix dialog buttons border colors #9501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When receiving a notification, the rust sdk always added _errors This caused hasError to return true and cause instance to not be saved despite the fact that for mails we had no errors. - This will solve the issue only for mails which originate from the case above, other issues such as contacts or files are *not* solved by this Co-authored-by: abp <abp@tutao.de> Co-authored-by: kib <104761667+kibibytium@users.noreply.github.com> Co-authored-by: jhm <17314077+jomapp@users.noreply.github.com> Co-authored-by: sug <sug@tutao.de>
Co-authored-by: das <das@tutao.de>
Co-authored-by: das <das@tutao.de>
- sync "Shield" and "BrokenShield" icons with fixed dimensions/viewBox - add "Duplicate" icon
charlag
approved these changes
Aug 13, 2025
Contributor
charlag
left a comment
charlag
left a comment
There was a problem hiding this comment.
I am a bit reluctant to extend Button with more options but I think for now it's the most sensible choice. Long term probably would need another button
Co-authored-by: das <das@tutao.de> Co-authored-by: jomapp <17314077+jomapp@users.noreply.github.com> Co-authored-by: abp <abp@tutao.de>
Contributor
Author
Yeah, extending it was the best working idea I could come up with, thanks for the review. |
- Dialogs buttons had an in between border that did not apply the right style, this happened because buttons always set a border color status. - This change always sets a value for button colors, using ButtonColor.Dialog
das-tuta
force-pushed
the
fix-dialog-border-color
branch
from
aaf7e0d to
fd60c5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially fixes: